Don't update dynamiccssrules on panning, add chromium percentage missing redraw workaround #140
+89
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const previousMaxDisplayedSize = this.getPreviousMaxDisplayedSize(); | ||
| // in case of bad or unset values NaN or Infinity, this condition is skipped and the function behaves as if zoom changed | ||
| if ( | ||
| Math.abs(previousMaxDisplayedSize - maxDisplayedSize) / previousMaxDisplayedSize < |
There was a problem hiding this comment.
in case of bad or unset values NaN or Infinity, this condition is skipped and the function behaves as if zoom changed
Comment on lines
1423
to
1436
| //Workaround chromium (tested on edge and google-chrome 131) doesn't | ||
| //redraw things with percentages on viewbox changes but it should, | ||
| //force it. Firefox does correctly redraw, but we force for everyone to | ||
| //have the same behavior everywhere and detect problems more easily. | ||
| //we can't use innerHtml+='' on the <style> tags because values set | ||
| //with setProperty(key, value) in updateSvgCssDisplayValue are not | ||
| //reflected in the html text so the innerHTML trick has the effect of | ||
| //resetting them. So instead of doing it on the svg, we do it on all | ||
| //its children that are not style elements. This won't work if there | ||
| //are deeply nested style elements that need dynamic css rules but in | ||
| //practice only the root style element hasdynamic rules so it's ok. | ||
| //remove this when chromium fixes their bug if this workaround causes | ||
| //problem, we can find a better way to force a redraw that doesnt | ||
| //change the elements in the dom |
There was a problem hiding this comment.
Suggested change
| //Workaround chromium (tested on edge and google-chrome 131) doesn't | |
| //redraw things with percentages on viewbox changes but it should, | |
| //force it. Firefox does correctly redraw, but we force for everyone to | |
| //have the same behavior everywhere and detect problems more easily. | |
| //we can't use innerHtml+='' on the <style> tags because values set | |
| //with setProperty(key, value) in updateSvgCssDisplayValue are not | |
| //reflected in the html text so the innerHTML trick has the effect of | |
| //resetting them. So instead of doing it on the svg, we do it on all | |
| //its children that are not style elements. This won't work if there | |
| //are deeply nested style elements that need dynamic css rules but in | |
| //practice only the root style element hasdynamic rules so it's ok. | |
| //remove this when chromium fixes their bug if this workaround causes | |
| //problem, we can find a better way to force a redraw that doesnt | |
| //change the elements in the dom | |
| //Workaround chromium (tested on edge and google-chrome 131) doesn't | |
| //redraw things with percentages on viewbox changes but it should, | |
| //so we force it. Firefox correctly redraws, but we force it for everyone to | |
| //have the same behavior everywhere and detect problems more easily. | |
| //We can't use innerHtml+='' on the <style> tags because values set | |
| //with setProperty(key, value) in updateSvgCssDisplayValue are not | |
| //reflected in the html text so the innerHTML trick has the effect of | |
| //resetting them. So instead of doing it on the svg, we do it on all | |
| //its children that are not style elements. This won't work if there | |
| //are deeply nested style elements that need dynamic css rules but in | |
| //practice only the root style element has dynamic rules so it's ok. | |
| //Remove this when chromium fixes their bug if this workaround causes | |
| //problem, we can find a better way to force a redraw that doesnt | |
| //change the elements in the dom |
jonenst
changed the title
jonenst
changed the title
YenguiSeddik
approved these changes
Dec 13, 2024
Signed-off-by: HARPER Jon <[email protected]>
This allows to see the effect of the workarounds for the css containing percent in the demo. And it's generally useful to have this kind of css when enabling level of detail Signed-off-by: HARPER Jon <[email protected]>
Signed-off-by: HARPER Jon <[email protected]>
Signed-off-by: HARPER Jon <[email protected]>
jonenst
force-pushed
the
fixsvgpercentwhenzoom
branch
from
912cebd to
52cdd79
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
NO
What kind of change does this PR introduce?
feature/bugfix
What is the current behavior?
css rules are updated when the viewbox changes, even for translations. But we only use the zoom level in rules
Also, chromium doesn't update the rendering when of percents (stroke-width), so add a workaround to force redraw
when the zoom changes by 1 percent
What is the new behavior (if this is a feature change)?
no update of rules during translations. Chromium redraw on zoom workaround (enabled all the time for consistency)
Does this PR introduce a breaking change or deprecate an API?
Other information:
we could split this PR in 2. We could enable the workaround only if we detect dynamic rules with percentages